victory icon indicating copy to clipboard operation
victory copied to clipboard

VictoryZoomContainer has slow zoom speed on Firefox

Open e-dong opened this issue 5 years ago • 13 comments

Bugs and Questions

Checklist

  • [x] This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • [x] I have read through the FAQ and Guides before asking a question

  • [x] I am using the latest version of Victory

  • [x] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

The zoom speed of the VictoryZoomContainer is very slow on firefox.

Reproduction

Navigate to the brush-and-zoom gallery on Chrome, Edge, IE11, Firefox: https://formidable.com/open-source/victory/gallery/brush-and-zoom

Notice how the zoom speed is extremely slow on Firefox. Other browsers work fine.

e-dong avatar Feb 14 '20 17:02 e-dong

Seems like there is also an issue with the wheel event.
See my other issue here: https://github.com/mdn/browser-compat-data/issues/5723

Noice how the zoom speed in firefox is also slow in the demo: https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event

e-dong avatar Feb 19 '20 13:02 e-dong

Hi @e-dong! What version of Firefox are you using? The demo works fine on my mac running 73.0.1.

narinluangrath avatar Mar 17 '20 04:03 narinluangrath

Thank you for the reply @narinluangrath !

I am using version: 68.5.0esr (32 bit) using windows 10. Due to my work environment, I am unable to update to the lastest Firefox.

UPDATE: On my personal computer, I have Firefox 74.0 on windows 10. I still observe the slow zoom speed.

e-dong avatar Mar 17 '20 16:03 e-dong

I am also noticing slow zoom speed in Firefox 77.0.1 on Windows 10.

soapnrope avatar Jun 15 '20 15:06 soapnrope

Same holds for me on Arch Linux with Firefox 78.0.1

wilecoyote2015 avatar Jul 09 '20 07:07 wilecoyote2015

Still having this issue in August, any fixes?

lukejriddle avatar Aug 17 '20 15:08 lukejriddle

@narinluangrath Likewise, very slow zoom speed on Firefox 81. Chart barely moves when zooming

Here I outputted domain.x on a normal zoom in Chrome, where each newline is one zoom in of scroll wheel

[0.9949124035714181, 9.227422403571333]
[1.814056949178552,  8.592156849178483]
[2.488485958395093,  8.06912154272837]
[3.0437658426500445, 7.638489140417776]
[3.535734899941149,  7.318723748436581]

And Firefox:

[0.05985115714285609, 9.958861157142755]
[0.11910380271428359, 9.919123702714185] 
[0.17818392268285468, 9.880203623682757] 
[0.2366732414517404,  9.841672745441642]
[0.29457766703293625, 9.80352717598294]
[0.3519030483583204,  9.765763062218824] 
[0.40865517587045064, 9.728376589592349]
[0.46483978210746035, 9.691363981692138]
[0.5204625422820994,  9.65472149987093] 
[0.5755290748549917,  9.618445442867936] 
[0.6300449421021554,  9.58253214643497]
[0.6840156506768481,  9.546977982966332] 
[0.7374466521657932,  9.511779361132383] 
[0.7899673008094642,  9.47655668268639]
[0.8419627429666992,  9.441686231024855] 
[0.8934382307023615,  9.407164483879935] 
[0.9443989635606671,  9.372987954206465] 
[0.9948500890903894,  9.33915318982973]
[1.0447967033648147,  9.305656773096763] 
[1.094243851496496,   9.272495320531124]
[1.1431965281468603,  9.239665482491143]
[1.191659678030721,   9.20716394283156]
[1.239638196415743,   9.174987418568573]
[1.2871369296169153,  9.143132659548217]
[1.3341606754860755,  9.111596448118064]
[1.3807141838965444,  9.080375598802213]
[1.4268021572229082,  9.04946695797952]
[1.4724292508160084,  9.018867403565055]

Venefilyn avatar Oct 14 '20 09:10 Venefilyn

Still an issue on Firefox 85, this time on Windows 10

Venefilyn avatar Jan 19 '21 00:01 Venefilyn

Did anyone find a fix for this?

addybongo avatar Mar 06 '21 15:03 addybongo

This is related to #655

becca-bailey avatar Feb 15 '22 18:02 becca-bailey

@becca-bailey slow in this case is the zoom amount, not performance. So they're two different issues

Venefilyn avatar Feb 15 '22 22:02 Venefilyn

Sorry, I think I missed that part of the discussion. I will keep this one open for now!

becca-bailey avatar Feb 16 '22 00:02 becca-bailey

@narinluangrath Any updates?

e-dong avatar Oct 03 '23 11:10 e-dong

This does not appear to be an issue in the latest version of Firefox. If anyone notices a similar problem, please open a new issue with a specific example and we can investigate further.

carbonrobot avatar Feb 23 '24 20:02 carbonrobot