victory icon indicating copy to clipboard operation
victory copied to clipboard

VictoryZoomContainer: no pinch to zoom on iOS?

Open mcintyre94 opened this issue 5 years ago • 8 comments

Bugs and Questions

Checklist

  • [x] This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • [x] I have read through the FAQ and Guides before asking a question

  • [x] I am using the latest version of Victory

  • [x] I've searched open issues to make sure I'm not opening a duplicate issue - may be a dupe of comments on this made after it was closed and not responded to, in 2017: https://github.com/FormidableLabs/victory/issues/434

The Problem

I'm unable to use pinch to zoom on iOS Safari on any VictoryZoomContainer charts.

Reproduction

Any of these charts in documentation:

  • https://formidable.com/open-source/victory/docs/victory-zoom-container
  • https://formidable.com/open-source/victory/guides/brush-and-zoom/
  • https://formidable.com/open-source/victory/guides/zoom-on-large-datasets

On all of these, on MacOS (at least in Firefox) a two-finger scroll zooms as expected, but on iOS pinch to zoom does not.

TBH I'm not 100% sure if this should be a feature request or a bug, is pinch-to-zoom supported on iOS?

mcintyre94 avatar Feb 13 '20 22:02 mcintyre94

Same thing on Android Chrome 84.x.

inspmoore avatar Aug 11 '20 10:08 inspmoore

Same thing on Android Chrome 86.x.

Adam-isdd avatar Nov 05 '20 16:11 Adam-isdd

Can I ask why this is closed? All 3 examples linked in my issue are still broken on iOS Safari.

mcintyre94 avatar Apr 13 '21 21:04 mcintyre94

+1

nes123 avatar Apr 27 '21 17:04 nes123

+1

brendanmorrell avatar Oct 08 '21 01:10 brendanmorrell

Any suggestions here? Seems onZoomDomainChange is fired every time I tried to zoom in on iOS, but nothing changed.

travor20814 avatar Oct 28 '21 12:10 travor20814

+1

jwh-hutchison avatar Nov 24 '21 15:11 jwh-hutchison

+1

Aryan-mor avatar Jan 30 '24 17:01 Aryan-mor

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] avatar May 01 '24 00:05 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

github-actions[bot] avatar May 09 '24 00:05 github-actions[bot]