spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

fixed link to contributing doc

Open jhumbug opened this issue 4 years ago • 1 comments

Fixed link to the contributing doc in the Tutorial

jhumbug avatar Mar 11 '21 20:03 jhumbug

After submitting this PR, I noticed that on staging the built docs are stripping .md from any markdown external link. So not only is that contrib link still not exactly working because of that, any other links to markdown files in the docs are 404ing.

It seems to be because of a react-static plugin as described here: https://github.com/kitten/react-static-plugin-md-pages#relative-links-fixes. I believe it's only supposed to strip relative links, but these aren’t relative and still getting stripped. So we may want to address that before merging this in.

jhumbug avatar Mar 15 '21 18:03 jhumbug

Uh oh, looks like Docusaurus found some broken links. If you run a local docusaurus build, you should be able to catch the broken links locally before it gets to CI.

gksander avatar Sep 19 '22 18:09 gksander

Yeah, I had been running it locally with the docusaurus start command but it didn't catch that double-.md one for whatever reason.

fritz-c avatar Sep 19 '22 18:09 fritz-c