spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

React 19 - defaultProps removed breaks stuff like FullScreen

Open AndyOGo opened this issue 8 months ago • 0 comments

Prerequisites

  • [x] I have searched the open issues to make sure I'm not opening a duplicate issue
    • https://github.com/FormidableLabs/spectacle/issues/1341
  • [x] I have read through the docs before asking a question
  • [x] I am using the latest version of Spectacle

Describe Your Environment

What version of Spectacle are you using? (can be found by running npm list --depth 0 spectacle)

[email protected]

What version of React are you using? (can be found by running npm list --depth 0 react)

[email protected]

What browser are you using? (e.g., Chrome 105.0.5195.102, Safari 16.0) Edge

What platform are you on? (e.g., Windows, macOS, iOS, Android) Windows

Describe the Problem

React 19 removed defaultProps and other APIs. https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Expected behavior: [What you expect to happen] <FullScreen> should have a default size

Actual behavior: [What actually happens] <FullScreen> has no default size

Additional Information

Affected code https://github.com/search?q=repo%3AFormidableLabs%2Fspectacle%20defaultProps%20&type=code

AndyOGo avatar May 09 '25 07:05 AndyOGo