spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

Infra: Bring `spectacle-mdx-loader` in to the monorepo

Open ryan-roemer opened this issue 1 year ago • 4 comments

  • [x] Add packages/spectacle-mdx-loader
  • [x] Add examples/mdx that uses the loader
  • [x] Remove old repository
  • [ ] Verify we can correctly publish.

ryan-roemer avatar Jul 28 '22 21:07 ryan-roemer

Got a branch in progress for this: https://github.com/FormidableLabs/spectacle/tree/chore/spectacle-mdx-loader-addition 👍

paulmarsicloud avatar Aug 26 '22 02:08 paulmarsicloud

Revisited this branch today and I'm a little stuck. On a fresh pnpm install and pnpm start:mdx, http://localhost:3300/ blank screens with a external var "React":1 Uncaught ReferenceError: React is not defined

When I exit and re-run pnpm start:mdx, I get many Module not found: Error: Can't resolve 'react/jsx-runtime' errors even though the module is safely there.

Will continue to chip away at this

paulmarsicloud avatar Sep 16 '22 02:09 paulmarsicloud

Hi @ryan-roemer , I'm looking back at this and it appears that the old repo is still out there and might cause confusion. Should we archive / delete it to finish out this project? I see in the initial checklist removing the old repo was part of the issue. We probably need to also verify npm publishing works as well.

cc @carbonrobot

Burnett2k avatar Mar 13 '24 15:03 Burnett2k

I think this is complete -- current version packages PR includes spectacle-mdx-loader. Plan sounds good -- verify npm publish, archive old repo. Thanks!

ryan-roemer avatar Mar 13 '24 16:03 ryan-roemer