spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

Fix error on start up in SSR environment

Open CodeWitchBella opened this issue 3 years ago • 0 comments

Description

Current code crashes when loaded in an environment without window global - eg. in node. It crashes even without actually rendering the code, so standard workaround of delaying render until client-side hydratation is not sufficient. This PR fixes that. To be clear: it does not enable SSR and instead only enables usage in codebase which uses SSR.

Related issue is #868 but this PR does not fix it, only allows user to work around it without patching the package.

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I ran yarn check-ci. Also this is based on a patch that I apply to my local spectacle installation.

Checklist

  • [ ] I did not add tests that prove my fix is effective or that my feature works, given that it is a one line change. Should I?

CodeWitchBella avatar Jun 09 '22 11:06 CodeWitchBella