spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

CodePane sometimes (?) scrolls entire portal up for the rest of the slideshow

Open sneakers-the-rat opened this issue 3 years ago • 1 comments

Describe Your Environment

What version of Spectacle are you using? (can be found by running npm list spectacle) 8.1

What version of React are you using? (can be found by running npm list react) 17.0.2

What browser are you using? Tested on Firefox & Chrome

What machine are you on? macOS

Describe the Problem

If there's enough code in a code slide that it has to slide up, CodeSlide will slide the entire slide window up, and it will stay up for the rest of the presentation. like so (note the black bar that appears at the bottom and top being cut off):

sadly_scroll_offscreen_forever

Interestingly, it only happens on versions that are built and deployed -- on the dev and prod versions, if i run it locally the window doesn't scroll, if i run the version that's deployed (via github pages w/ a gh action that shouldn't be any different than me building it fresh locally) then it does.

If i change the overflow property of whatever div is just below id='root' but above Deck (i'm using mdx so it might be the MDXProvider) from overflow: hidden to overflow: visible or overflow: clip it fixes the behavior for some reason.

seems like either the window shouldn't scroll, or the code pane should -- currently i can't use the component because of the problem, and am not really sure why it's happening because i don't understand the inner workings of the portal yet.

Expected behavior: [What you expect to happen]

for the CodePane to scroll

Actual behavior: [What actually happens]

the Whole Window scrolls.

sneakers-the-rat avatar May 19 '21 01:05 sneakers-the-rat

bump bc this totally breaks this component and i want to use it! haven't been able to figure out a workaround but will PR if i do

sneakers-the-rat avatar Sep 28 '21 23:09 sneakers-the-rat