react-live icon indicating copy to clipboard operation
react-live copied to clipboard

fix: add tab gate to disable focus trap

Open stephen-pearce opened this issue 1 year ago • 2 comments

Description

Add tab gate triggered by ESC key and disabled by refocusing the editor or container

https://github.com/user-attachments/assets/1f51cae2-1e85-41ce-8c7e-54c6e515fd98

Fixes #390

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • [x] I have included a changeset if this change will require a version change to one of the packages.
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] I have run all builds, tests, and linting and all checks pass
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

stephen-pearce avatar Oct 08 '24 17:10 stephen-pearce

🦋 Changeset detected

Latest commit: cb98b5120a34c7e569f3fd0f5d36ac8c9afe0277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-live Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 08 '24 17:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:15pm

vercel[bot] avatar Oct 08 '24 17:10 vercel[bot]