react-live icon indicating copy to clipboard operation
react-live copied to clipboard

Add tabMode prop

Open selbekk opened this issue 2 years ago • 2 comments

This pull request adds a new prop for LiveEditor - tabMode - which lets you define how the tab key should work.

If you pass the value indentation (the default), everything will work as it has. If you pass focus, however, you'll be able to tab on to the next or previous item in the tab order, which is a WCAG requirement.

You could then implement a way to change this mode based on user settings, an external checkbox or whatever, really.

Fixes #179

selbekk avatar Mar 25 '22 09:03 selbekk

@selbekk, thanks for opening this PR! I hope it gets merged soon. Until then, are there any workarounds you'd recommend?

sserrata avatar Jul 07 '22 15:07 sserrata

Any update on this?

holloway avatar Aug 18 '22 21:08 holloway

@selbekk @sserrata @holloway

Happy to say this has been merged in and now available on 3.1.2!

Sorry for the delay, we haven't had an active maintainer on this package in a while. Appreciate your work here!

scottianstewart avatar Feb 20 '23 17:02 scottianstewart

Sorry for the delay, we haven't had an active maintainer on this package in a while.

Wonderful to hear you're back on track 🎉 Appreciated.

selbekk avatar Feb 21 '23 12:02 selbekk