react-game-kit icon indicating copy to clipboard operation
react-game-kit copied to clipboard

Works in chrome 54 breaks in chrome 55

Open wdjungst opened this issue 8 years ago • 5 comments

Demo game played fine then I updated chrome and get this err: Cannot read property 'id' of null

function transformGamepad(threshold, gamepad) { var gp = { id: gamepad.id, <(----THIS gamepad is undefined buttons: {}, axes: {} };

wdjungst avatar Dec 07 '16 03:12 wdjungst

I should mention this is an issue with a dependency html5-gamepad

wdjungst avatar Dec 07 '16 04:12 wdjungst

i'm facing the same problem here: https://incidents-attack.firebaseapp.com

Broke in chrome 55 update. Works fine in FF and Safari.

image

dorsha avatar Dec 11 '16 22:12 dorsha

I've removed gamepad support in my fork, and it at least runs now. Might help those of you who just need keyboard controls. https://github.com/eschaefer/react-game-kit/tree/feature/no-gamepad

eschaefer avatar Jan 09 '17 20:01 eschaefer

Great catch, removing gamepad bc of this

kenwheeler avatar Jan 25 '17 16:01 kenwheeler

@kenwheeler @eschaefer I noticed that the version of html5-gamepad was pretty out of date. Did you guys try updating it first?

Current Version: v1.0.1 package.json Version: v0.1.4

https://www.npmjs.com/package/html5-gamepad

Swivelgames avatar Apr 05 '17 23:04 Swivelgames