nuka-carousel icon indicating copy to clipboard operation
nuka-carousel copied to clipboard

Body scroll disabled

Open chocovelod opened this issue 2 years ago • 7 comments

Hey! The body does not scroll vertically on the carousel, how can this be fixed?

chocovelod avatar Jun 21 '22 07:06 chocovelod

Hey @chocovelod, could you give more information, what you mean about body doesn't scroll vertically? Screenshot and code sandbox it will be useful

ValGeorgiev avatar Jun 21 '22 07:06 ValGeorgiev

Снимок экрана 2022-06-21 в 10 41 56

I cant scroll page when my finger on carousel container. Only carousel items swiping.

chocovelod avatar Jun 21 '22 07:06 chocovelod

Hey, I was about to make an issue about this. I've made a small sandbox to exemplify the problem, I am assuming we have the same issue. https://codesandbox.io/s/condescending-rgb-3w5stf?file=/src/App.js

If dragging is false and swiping is true, the carousel does not slide on swipe for mobile. If both are true and the carousel occupies a significant space on the mobile screen (as it is often the case) we cannot scroll down the page anymore.

EDIT: this only happens on v5, I was previously using v4.8.3 and it was working fine. I did check all breaking changes but is there something I missed?

Rawphs avatar Jun 21 '22 08:06 Rawphs

I was able to reproduce it on real device, I will have a look. Thanks for letting us know

ValGeorgiev avatar Jun 21 '22 08:06 ValGeorgiev

Im using 5.0.16v and it doest help

chocovelod avatar Jun 21 '22 08:06 chocovelod

FYI: this was disabled because of this issue. #874 . I am looking for a fix, that will make everyone happy :)

ValGeorgiev avatar Jun 21 '22 09:06 ValGeorgiev

I think it's nice to have some property that can change overflow-y to "auto". Might be helpful

chocovelod avatar Jun 21 '22 10:06 chocovelod

As of 5.2.0, this has been fixed. You can test here to see: https://codesandbox.io/s/blazing-moon-duy07s

fritz-c avatar Aug 18 '22 18:08 fritz-c