formidable-landers icon indicating copy to clipboard operation
formidable-landers copied to clipboard

Spectacle Editor builds should live on CDN

Open coopy opened this issue 7 years ago • 6 comments

the .dmg and .exe files are currently hosted straight on our Wordpress web server. This is not ideal in terms of download speed and load (not sure if we get charged extra for high traffic volume). In the worst case, it could degrade performance of the whole website.

@ryan-roemer This would involve pushing builds to an S3-bucket, and pointing the lander page links to CloudFront URLs, yeah?

We could wait with this until we're deploying our whole site to CDN, depending on how long that will take. I'd like to have SpecEd installable from CDN by mid-November.

coopy avatar Oct 13 '16 04:10 coopy

This is the OSS project https://github.com/FormidableLabs/spectacle-editor ?

If so, suggest instead following the path of phantomjs-prebuilt using the Github Release feature to attach binaries to.

For example, phantomjs-prebuilt adds platform specific binaries in compressed format for all OS's (not part of source) like https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2

Also great way to have a one-stop process for releases and one source of truth (github)!

ryan-roemer avatar Oct 13 '16 16:10 ryan-roemer

Now that I'm trying to port the WP site to static, I'm seeing that these files are huge clocking in at:

 49M    site/open-source/spectacle-editor/static/Spectacle Editor.dmg
 36M    site/open-source/spectacle-editor/static/Spectacle Editorx86.exe

for an entire static site that is in total (with these):

127M    site/

Let's prioritize getting these files out of the landers / our website and onto GitHub for downloading if we can.

Thanks!

ryan-roemer avatar Oct 19 '16 04:10 ryan-roemer

Additionally, let's change the filenames to something with the version in there and without spaces. I think the GitHub release process might do this automatically, in which case awesome!

ryan-roemer avatar Oct 19 '16 04:10 ryan-roemer

@ryan-roemer The files are hosted here: https://github.com/FormidableLabs/spectacle-editor-docs/tree/master/static

I’m not clear on what’s expected from me or what changes need to be made. In the build-static task for the dox, the /static/ folder is where the assets live and is automatically copied to the server. So, these files would just need to live elsewhere in order to avoid being copied to the server.

/cc @rgerstenberger @bmathews

paulathevalley avatar Oct 19 '16 18:10 paulathevalley

@paulathevalley -- I don't really mind what happens as long as they don't end up in the website.

But a secondary concern is the repo also pays the price for size and doesn't need to.

Let's ticket out and get on:

  • [x] Remove files from the website. Can temporarily move to another directory that isn't copied to the website and we direct link here to github branch.
  • [ ] After, remove from git repo and move to release workflow (or something similar)

ryan-roemer avatar Oct 19 '16 18:10 ryan-roemer

I've uploaded the binaries to the spectacle-editor gh release: https://github.com/FormidableLabs/spectacle-editor/releases/tag/v0.1.3

The binaries can be removed from the spectacle-editor-docs repo and the links can be updated to point to the new location.

bmathews avatar Oct 19 '16 19:10 bmathews