Octolapse
Octolapse copied to clipboard
Installing in octo4a fails (compilation error)
If this is a feature request describe it here
___REPLACE_THIS__FEATURE_REQUEST_DESCRIPTION_GOES_HERE
Version of Octolapse
Octolapse Version: fails to install "master.zip" on 2023-06-03
Version of OctoPrint
OctoPrint Version: 1.9.0
When you ran into the problem, did you have diagnostic logging enabled?
Diagnostic Logging was Enabled: No (I don't think I can, during the plugin installation process)
What were you doing when the problem occurred
- Open OctoPrint Settings -> Plugin Manager
- Click "Get More"
- Click "Install" button next to OctoLapse
What should have happened?
It should have installed the latest OctoLapse
What happened instead?
OctoPrint tried multiple times to install, but failed.
Operating System running OctoPrint and Octolapse
OS Name: Android Os Version: 10
octo4a version 1.2.4
The rest of this template seems not relevant to an install-time problem. But what is presumably relevant is the error from the install log. Plenty of warnings, but just this one error section:
from octoprint_octolapse/data/lib/c/gcode_position_processor.cpp:24: octoprint_octolapse/data/lib/c/gcode_position_processor.cpp: In function 'bool ParseStabilizationArgs(PyObject*, stabilization_args*, PyObject**, PyObject**)': octoprint_octolapse/data/lib/c/gcode_position_processor.cpp:1404:24: error: converting to 'bool' from 'std::nullptr_t' requires direct-initialization [-fpermissive] 1404 | return NULL;
I note that all the other "if" conditions return "false", but this particular one returns NULL It's been too long for me to have an opinion on the specific casting error/restriction this is complaining about, but maybe it's a simple fix?
https://github.com/FormerLurker/Octolapse/blame/8d53c91069943b9b4d78498c2fc225b3d6d04cb8/octoprint_octolapse/data/lib/c/gcode_position_processor.cpp#L1404