Installing in octo4a fails (compilation error)

[philipp]

If this is a feature request describe it here

___REPLACE_THIS__FEATURE_REQUEST_DESCRIPTION_GOES_HERE

Version of Octolapse

Octolapse Version: fails to install "master.zip" on 2023-06-03

Version of OctoPrint

OctoPrint Version: 1.9.0

When you ran into the problem, did you have diagnostic logging enabled?

Diagnostic Logging was Enabled: No (I don't think I can, during the plugin installation process)

What were you doing when the problem occurred

1. Open OctoPrint Settings -> Plugin Manager
2. Click "Get More"
3. Click "Install" button next to OctoLapse

What should have happened?

It should have installed the latest OctoLapse

What happened instead?

OctoPrint tried multiple times to install, but failed.

Operating System running OctoPrint and Octolapse

OS Name: Android Os Version: 10

octo4a version 1.2.4

The rest of this template seems not relevant to an install-time problem. But what is presumably relevant is the error from the install log. Plenty of warnings, but just this one error section:

from octoprint_octolapse/data/lib/c/gcode_position_processor.cpp:24: octoprint_octolapse/data/lib/c/gcode_position_processor.cpp: In function 'bool ParseStabilizationArgs(PyObject*, stabilization_args*, PyObject**, PyObject**)': octoprint_octolapse/data/lib/c/gcode_position_processor.cpp:1404:24: error: converting to 'bool' from 'std::nullptr_t' requires direct-initialization [-fpermissive] 1404 | return NULL;

I note that all the other "if" conditions return "false", but this particular one returns NULL It's been too long for me to have an opinion on the specific casting error/restriction this is complaining about, but maybe it's a simple fix?

https://github.com/FormerLurker/Octolapse/blame/8d53c91069943b9b4d78498c2fc225b3d6d04cb8/octoprint_octolapse/data/lib/c/gcode_position_processor.cpp#L1404

[Truscorpio82]

Mine is failing as well, would there be a solution for this?

[chis54]

I'm having what might be the same issue. Fresh installation of Octo4a v1.2.5. Octolapse plugin installation fails every time. Here is the log: octolapseinstall.log Installing other plugins seem to work just fine.

UPDATE: I tried installing older versions of Octolapse and the installation continues to fail. However, I installed v0.3.4 and while it did install successfully, it is not compatible with the latest version of Octoprint.

UPDATE 2: I was able to install the plugin from this fork: https://github.com/FormerLurker/Octolapse/issues/888#issuecomment-1476793545 This is the solution for the time being.

[philipp]

I thought I had tried that. I guess not. Notably, it seems to have successfully installed from that fork, even though the log of the install showed multiple errors (all related to Pillow) Now of course it's prompting me to update to the latest (4.3 from this 4.1+commit version, and the changelogs suggest I might actually want to, since I use SuperSlicer) But I think I'll just try it out this way first, and see what happens. Must. Resist. Pressing "Update now"!

[philipp]

I've forked the current "master" and made a single change, reflecting what I described in this issue. I changed NULL on line 1404 of octoprint_octolapse/data/lib/c/gcode_position_processor.cpp to false And with that change, the installation succeeds! I've created a Pull Request, but until that gets attention from @FormerLurker you can try installing from https://github.com/philipp/Octolapse/archive/refs/heads/philipp-issue-911.zip and see if it behaves for you. I'm an OctoLapse noob, so unless it goes horribly wrong, I'm not sure I'd know if there were subtle problems introduced :-)

[Obagunceiro]

I've forked the current "master" and made a single change, reflecting what I described in this issue. I changed NULL on line 1404 of octoprint_octolapse/data/lib/c/gcode_position_processor.cpp to false And with that change, the installation succeeds! I've created a Pull Request, but until that gets attention from @FormerLurker you can try installing from https://github.com/philipp/Octolapse/archive/refs/heads/philipp-issue-911.zip and see if it behaves for you. I'm an OctoLapse noob, so unless it goes horribly wrong, I'm not sure I'd know if there were subtle problems introduced :-)

That worked flawlessly!! thanks so much!

[gglockner]

@philipp : Thanks for your help on this. I do get past the g++ error, but I get a different error when I build the wheel:

WARNING: Built wheel for Octolapse is invalid: Metadata 1.2 mandates PEP 440 version, but 'philipp-issue-911' is not
ERROR: Could not build wheels for Octolapse, which is required to install pyproject.toml-based projects
Building wheel for Octolapse (setup.py): finished with status 'done'
Created wheel for Octolapse: filename=Octolapse-philipp_issue_911-cp310-cp310-linux_aarch64.whl size=3147853 sha256=ad506701b889fb9205d3c8a8a849394eaa15b882a6a77d8961e04c79eb1892dc
Stored in directory: /tmp/pip-ephem-wheel-cache-cjslys02/wheels/c5/69/a0/d968101b1a55c091a2bdbd012f4ae795484bcb9509bb742c38
Failed to build Octolapse
Error!
Could not parse output from pip, see plugin_pluginmanager_console.log for generated output

[philipp]

@philipp : Thanks for your help on this. I do get past the g++ error, but I get a different error when I build the wheel:

@gglockner: No idea what that might mean, but I do notice that there's a newer version of Octoprint out now. I'm still on 1.9.1, and that's what I was successful with. Are you using 1.9.2? Maybe there's some difference that breaks something else.

[HaraldBluet00th]

I've forked the current "master" and made a single change, reflecting what I described in this issue. I changed NULL on line 1404 of octoprint_octolapse/data/lib/c/gcode_position_processor.cpp to false And with that change, the installation succeeds! I've created a Pull Request, but until that gets attention from @FormerLurker you can try installing from https://github.com/philipp/Octolapse/archive/refs/heads/philipp-issue-911.zip and see if it behaves for you. I'm an OctoLapse noob, so unless it goes horribly wrong, I'm not sure I'd know if there were subtle problems introduced :-)

Thank you for this - hours of searching brought me here and its the only thing that has worked so far.

[JDMorrison75]

I am using 1.9.2 and every time I get to building the wheel I get an error and it fails to install. plugin_pluginmanager_console (2).log