Octolapse icon indicating copy to clipboard operation
Octolapse copied to clipboard

Published 20 hours ago • verified publisher icon FormerLurker

Add timelapse preview to file browser

Open ssendev opened this issue 4 years ago • 5 comments

Implementation copied from

https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/static/js/app/viewmodels/timelapse.js#L308-L318

https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/templates/dialogs/timelapse.jinja2

There were some access checks in the original file browser which the download in Octolapse didn't have so i didn't add one to the preview

also there were quite some variations for function() { so i choose my preferred style

ssendev avatar Jan 16 '21 04:01 ssendev

Cool! I will check this out asap.

FormerLurker avatar Jan 16 '21 06:01 FormerLurker

Question: What formats does the player support? I see you have reused the OctoPrint player template, which isn't working for the default video type for me (.mp4) for some reason.

FormerLurker avatar Jan 18 '21 19:01 FormerLurker

It depends on your browser H264 is supported by most

ssendev avatar Jan 18 '21 19:01 ssendev

It depends on your browser H264 is supported by most

https://caniuse.com/mpeg4

mawoka-myblock avatar Nov 29 '21 16:11 mawoka-myblock

I'm going to reexamine this PR ASAP. Working on a new release, so it's a good time!

FormerLurker avatar Nov 29 '21 16:11 FormerLurker