ArcWelderPlugin icon indicating copy to clipboard operation
ArcWelderPlugin copied to clipboard

Updater not working under OctoPrint v1.8.0

Open Taomyn opened this issue 2 years ago • 5 comments

I have updated to OctoPrint v1.8.0 (RPi 4) and everything looks fine except now when I perform a software update check it fails for ArcWelder:

image

2022-05-18 06:49:06,867 - octoprint.plugins.softwareupdate - ERROR - Could not check arc_welder for updates
Traceback (most recent call last):
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/plugins/softwareupdate/__init__.py", line 1835, in _get_current_version
    target, check, online=online, credentials=credentials
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/plugins/softwareupdate/version_checks/github_release.py", line 276, in get_latest
    target
octoprint.plugins.softwareupdate.exceptions.ConfigurationInvalid: Update configuration for arc_welder of type github_release needs all of user, repo and current set and not None
2022-05-18 06:49:07,039 - octoprint.plugins.softwareupdate - INFO - Saved version cache to disk
2022-05-18 06:49:12,510 - octoprint.plugins.softwareupdate - INFO - Fetching check overlays from https://plugins.octoprint.org/update_check_overlay.json
2022-05-18 06:49:12,711 - octoprint.plugins.softwareupdate - ERROR - Could not check arc_welder for updates
Traceback (most recent call last):
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/plugins/softwareupdate/__init__.py", line 1835, in _get_current_version
    target, check, online=online, credentials=credentials
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/plugins/softwareupdate/version_checks/github_release.py", line 276, in get_latest
    target
octoprint.plugins.softwareupdate.exceptions.ConfigurationInvalid: Update configuration for arc_welder of type github_release needs all of user, repo and current set and not None

I have tried all the release channels and they do the same, although the plug-in itself does seem to be still working for now.

Taomyn avatar May 18 '22 04:05 Taomyn

Yeah, this has been broken since the beginning due to a typo in the plugin definition. I need to submit a pull request for Octoprint to fix existing installs. V sorry about that!

FormerLurker avatar Jun 07 '22 19:06 FormerLurker

Has this been abandoned?

Taomyn avatar Oct 31 '22 05:10 Taomyn

@Taomyn, no it isn't. Just had to take a bit of a break. It's going to take a while to get to the backlog.

FormerLurker avatar Nov 02 '22 17:11 FormerLurker

@FormerLurker no worries, no other issues with the plugin, just spotted when looking at another problem with my OctoPrint updates and thought I'd check here.

Taomyn avatar Nov 03 '22 08:11 Taomyn

Yeah, troubling that plugin check-for-update won't work. Sounds like a simple fix (always "sounds like...", I know): just provide the right release and repo and user info, IIRC.

jimmiedave avatar Jan 09 '23 00:01 jimmiedave