foundryvtt-forien-quest-log icon indicating copy to clipboard operation
foundryvtt-forien-quest-log copied to clipboard

[BUG] Window for Module doesn't close after clicking save (or close) for new quests.

Open dmkuda opened this issue 4 years ago • 5 comments

Module Version: v0.3.0

Describe the bug I'm unable to close the dialogue window after creating a new quest. The modal window appears, allows me to make the quest, but does not close when I click save or "close". Only broke after new version of Foundry.

Foundry Version: Foundry Version: 0.7.6 Game System: Dnd5e

dmkuda avatar Nov 08 '20 16:11 dmkuda

Verified that this was the only mod running and same behavior.

dmkuda avatar Nov 09 '20 16:11 dmkuda

Confirmed.

rholman-PRFT avatar Nov 09 '20 22:11 rholman-PRFT

Same here.

Jason-Terry avatar Nov 11 '20 22:11 Jason-Terry

I've found a fix for this.

If you replace lines 145-148 in quest-form.mjs with: async close(options) { if (this.submitted) { return super.close(options); }

I've been able to get normal functionality.

I should add, this was only possible thanks to the work of JDW on Dice so Nice which had a similar issue.

velara avatar Nov 13 '20 19:11 velara

Confirmed.  Thank you!!! On Friday, November 13, 2020, 12:44:07 PM MST, velara [email protected] wrote:

I've found a fix for this.

If you replace lines 145-148 in quest-form.mjs with: async close(options) { if (this.submitted) { return super.close(options); }

I've been able to get normal functionality.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

dmkuda avatar Nov 13 '20 20:11 dmkuda