forest-rails icon indicating copy to clipboard operation
forest-rails copied to clipboard

Usage of rails secrets raises deprecation warnings on Rails 7.1+

Open dvkch opened this issue 1 year ago • 2 comments

Hi there,

I am currently in the process of migrating a Rails app to Rails 7.1, and I found that Forest's usage of Rails.application.secrets usage in boostrapper.rb raises a deprecation warning/exception (depending on your configuration).

This check seems to have been there for 2 years now, would it be possible to remove it ? Or at least check only if ForestLiana.application_url hasn't already been set before.

For reference, here is the offending line: https://github.com/ForestAdmin/forest-rails/blob/8cbdea38c7d38d7f31a0f4d3b54f926d506421e0/lib/forest_liana/bootstrapper.rb#L31

Thank you for considering :)

dvkch avatar Feb 07 '24 16:02 dvkch

Hi @dvkch , thanks for your feedback

I have just created a ticket on our end to remove this warning. I will let you know when it's processed.

matthv avatar Feb 08 '24 13:02 matthv

Thank you !

dvkch avatar Feb 08 '24 16:02 dvkch

:tada: This issue has been resolved in version 9.3.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

forest-bot avatar Jun 14 '24 13:06 forest-bot

hello @dvkch, I have just released version 9.3.10 which removes the deprecated warning.

matthv avatar Jun 14 '24 13:06 matthv

Great, thanks for the update!

dvkch avatar Jun 15 '24 15:06 dvkch