[-] Liana Login - Better error handling if environment variables are missing.

[arnaudbesnier]

Expected behavior

If the env_secret or auth_secret is missing, we need an explicit error message on liana login.

Actual behavior

Misleading error messages.

Missing auth_secret:

Started POST "/forest/sessions" for 127.0.0.1 at 2019-04-26 10:14:41 +0200
Processing by ForestLiana::SessionsController#create_with_password as HTML
  Parameters: {"email"=>"[email protected]", "password"=>"[FILTERED]", "token"=>nil, "twoFactorRegistration"=>false, "renderingId"=>"33027", "projectId"=>"24305"}
[2019-04-26 10:14:41] Forest 🌳🌳🌳  no implicit conversion of nil into String
[2019-04-26 10:14:41] Forest 🌳🌳🌳  /Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/algos/hmac.rb:14:in `digest'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/algos/hmac.rb:14:in `sign'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/signature.rb:35:in `sign'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/encode.rb:39:in `encoded_signature'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/encode.rb:47:in `encode_segments'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt/encode.rb:20:in `initialize'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt.rb:21:in `new'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/jwt-2.1.0/lib/jwt.rb:21:in `encode'
/Users/arnaudbesnier/Dev/forest-rails/app/services/forest_liana/login_handler.rb:96:in `create_token'
/Users/arnaudbesnier/Dev/forest-rails/app/services/forest_liana/login_handler.rb:45:in `perform'
/Users/arnaudbesnier/Dev/forest-rails/app/controllers/forest_liana/sessions_controller.rb:70:in `process_login'
/Users/arnaudbesnier/Dev/forest-rails/app/controllers/forest_liana/sessions_controller.rb:12:in `create_with_password'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/abstract_controller/base.rb:194:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/rendering.rb:30:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/callbacks.rb:132:in `run_callbacks'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/abstract_controller/callbacks.rb:41:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/rescue.rb:22:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/notifications.rb:168:in `block in instrument'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/notifications.rb:168:in `instrument'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activerecord-5.2.0/lib/active_record/railties/controller_runtime.rb:24:in `process_action'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/abstract_controller/base.rb:134:in `process'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionview-5.2.0/lib/action_view/rendering.rb:32:in `process'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal.rb:191:in `dispatch'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_controller/metal.rb:252:in `dispatch'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb:34:in `serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:35:in `each'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:35:in `serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb:840:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/engine.rb:524:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/railtie.rb:190:in `public_send'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/railtie.rb:190:in `method_missing'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/mapper.rb:48:in `serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:35:in `each'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb:35:in `serve'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb:840:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/tempfile_reaper.rb:15:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/etag.rb:25:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/conditional_get.rb:38:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/head.rb:12:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/http/content_security_policy.rb:18:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:232:in `context'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/session/abstract/id.rb:226:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/cookies.rb:670:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activerecord-5.2.0/lib/active_record/migration.rb:559:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/callbacks.rb:98:in `run_callbacks'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/executor.rb:14:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/web-console-3.5.1/lib/web_console/middleware.rb:135:in `call_app'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/web-console-3.5.1/lib/web_console/middleware.rb:28:in `block in call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/web-console-3.5.1/lib/web_console/middleware.rb:18:in `catch'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/web-console-3.5.1/lib/web_console/middleware.rb:18:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/rack/logger.rb:38:in `call_app'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/rack/logger.rb:26:in `block in call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb:71:in `block in tagged'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb:28:in `tagged'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb:71:in `tagged'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/rack/logger.rb:26:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/sprockets-rails-3.2.1/lib/sprockets/rails/quiet_assets.rb:13:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/request_id.rb:27:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/method_override.rb:22:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/runtime.rb:22:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/activesupport-5.2.0/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/executor.rb:14:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/actionpack-5.2.0/lib/action_dispatch/middleware/static.rb:127:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-2.0.4/lib/rack/sendfile.rb:111:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/rack-cors-1.0.2/lib/rack/cors.rb:97:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/railties-5.2.0/lib/rails/engine.rb:524:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/puma-3.11.3/lib/puma/configuration.rb:225:in `call'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/puma-3.11.3/lib/puma/server.rb:624:in `handle_request'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/puma-3.11.3/lib/puma/server.rb:438:in `process_client'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/puma-3.11.3/lib/puma/server.rb:302:in `block in run'
/Users/arnaudbesnier/.rvm/gems/ruby-2.4.1/gems/puma-3.11.3/lib/puma/thread_pool.rb:120:in `block in spawn_thread'
Completed 500 Internal Server Error in 119ms (Views: 0.2ms | ActiveRecord: 0.0ms)

Missing env_secret:

Started POST "/forest/sessions" for 127.0.0.1 at 2019-04-26 10:23:19 +0200
Processing by ForestLiana::SessionsController#create_with_password as HTML
  Parameters: {"email"=>"[email protected]", "password"=>"[FILTERED]", "token"=>nil, "twoFactorRegistration"=>false, "renderingId"=>"33027", "projectId"=>"24305"}
[2019-04-26 10:23:19] Forest 🌳🌳🌳  An error occured while retrieving your IP whitelist. Your Forest env_secret seems to be missing or unknown. Can you check that you properly set your Forest env_secret in the forest_liana initializer?
Filter chain halted as :reject_unauthorized_ip rendered or redirected
Completed 403 Forbidden in 6ms (Views: 0.2ms | ActiveRecord: 0.0ms)

Context

• Package Version: 3.0.0
• Rails Version: any
• Database Dialect: any
• Database Version: any