barcodebuddy-homeassistant icon indicating copy to clipboard operation
barcodebuddy-homeassistant copied to clipboard

Missing persistent storage in Dockerfile / no data saved

Open Paddy0174 opened this issue 4 years ago • 6 comments

The addOn doesn't store data in a persistent storage, leading to loosing all data after a shutdown/restart.

As far as I know there should be a WORKDIR in the Dockerfile to set this up.

Reproduce:

  • install addOn
  • configure it (user, API key)
  • restart addOn
  • all data is missing including the first user

Paddy0174 avatar Mar 08 '21 13:03 Paddy0174

Thank for the report! It seems that HASS requires data to be stored in the path /data, which means that the base docker image needs to be modified. I created an issue in the repo https://github.com/Forceu/barcodebuddy-docker/issues/14 and will have a look at it in the next days.

Forceu avatar Mar 08 '21 14:03 Forceu

Not totally sure about that, as the WORKDIR in almost all addOns (official ones) use only / and not /data? The letsencrypt and homematic addOns are the only ones with a specific notation to /usr/src.

See here: https://github.com/home-assistant/addons/search?q=WORKDIR

I'll install a changed version (just setting WORKDIR to /) in the next days and see what comes up. :) I'll report back. In the meantime I'll just do a partial snapshot only for BCB and restore if necessary.

Should I use this issue or https://github.com/Forceu/barcodebuddy-docker/issues/14 to report?

Paddy0174 avatar Mar 08 '21 18:03 Paddy0174

No workdir has nothing to do with it, HASS only mounts the a /data volume by default. I modified the config file, can you try if it works now?

Forceu avatar Mar 10 '21 21:03 Forceu

Unfortunately it doesn't seem to fix the issue.

But I have to admit I'm not sure how that worked... I didn't do anything to update the HA-addOn, but it seems it was updated automatically (I don't have the option for automatic update enabled)? Nonetheless I checked the file config.json and your changes were in there. After that I restarted the addOn (three times), it unfortunately didn't work. It still doesn't save the data. :(

Paddy0174 avatar Mar 11 '21 22:03 Paddy0174

Edit: re-wrote this after some new input on another addon, now much shorter.

You probably want to store files in /data and not use /config at all. If you make sure barcodebuddy.db is somewhere in /data I believe that would be enough.

fredrikbaberg avatar Apr 08 '21 15:04 fredrikbaberg

I am really sorry guys, I completely forgot about this issue, as I am not using the HA image. I linked the /config volume to /data in the current image, does this fix the issue?

Forceu avatar May 11 '23 18:05 Forceu