github-real-names icon indicating copy to clipboard operation
github-real-names copied to clipboard

Doesn't work in GitHub Enterprise

Open vasilescur opened this issue 6 years ago • 3 comments

This plugin does not seem to work on an Enterprise GitHub, where the URL is on a sub-domain of my company.

For example, I'm on something like github.XXX.COMPANY.com, and the names are not replaced.

vasilescur avatar Jun 14 '18 14:06 vasilescur

A pull request would be welcomed. I don't use GitHub Enterprise myself, so I can't test it there.

ForbesLindesay avatar Jun 18 '18 10:06 ForbesLindesay

Plugin is using hard-coded github.com url to access user API: https://github.com/ForbesLindesay/github-real-names/blob/master/index.js#L19

Maybe the only thing to do would be to make this url configurable, but i have no skill to do that :(

geoffroyjabouley avatar Sep 19 '18 08:09 geoffroyjabouley

It's also only applied to the github.com domain: https://github.com/ForbesLindesay/github-real-names/blob/master/manifest.json#L25

ForbesLindesay avatar Jan 15 '19 15:01 ForbesLindesay