acorn-globals icon indicating copy to clipboard operation
acorn-globals copied to clipboard

support catch without error

Open LongTengDao opened this issue 4 years ago • 5 comments

try { }
catch { }

LongTengDao avatar Mar 24 '20 17:03 LongTengDao

I came across this bug as well. Thanks @LongTengDao for the fix. Any chance this can be merged?

corwin-of-amber avatar Jul 02 '20 11:07 corwin-of-amber

cross this bug as well. Thanks @LongTengDao for the fix. Any chance this can be merged?

I think @ForbesLindesay is busy, I'm waiting for his time.

LongTengDao avatar Jul 02 '20 12:07 LongTengDao

Facing the same issue. @ForbesLindesay can you please merge this to enable optional catch binding?

pronav avatar Aug 25 '21 03:08 pronav

Or, can you please give @LongTengDao permission to update the NPM package?

corwin-of-amber avatar Aug 25 '21 08:08 corwin-of-amber

@ForbesLindesay Can you take a quick peek? :)

nicolashenry avatar Dec 16 '21 18:12 nicolashenry

Change Log for acorn-globals (6.0.0 → 6.0.1)

Bug Fixes

  • Support catch handler without binding the error to a variable

Edit changelog

rollingversions[bot] avatar Aug 31 '22 10:08 rollingversions[bot]

@LongTengDao Sorry for the (extreme) delay in reviewing this. I'll add you as a contributor so you can review & merge changes in future.

I've set up Rolling Versions now so that contributors on GitHub can release new versions via CI after merging changes. Just click the "Rolling Versions: Enabled" badge in the README to preview & trigger the next release. Where possible, please try to get a second review on any changes you make yourself, but feel free to merge if nobody has responded within a week or so. Please never commit directly to the "master" branch.

ForbesLindesay avatar Aug 31 '22 11:08 ForbesLindesay

@LongTengDao Sorry for the (extreme) delay in reviewing this. I'll add you as a contributor so you can review & merge changes in future.

I've set up Rolling Versions now so that contributors on GitHub can release new versions via CI after merging changes. Just click the "Rolling Versions: Enabled" badge in the README to preview & trigger the next release. Where possible, please try to get a second review on any changes you make yourself, but feel free to merge if nobody has responded within a week or so. Please never commit directly to the "master" branch.

@ForbesLindesay Thanks for trust. I just saw the invitation message, it has expired, sorry.

LongTengDao avatar Dec 27 '22 22:12 LongTengDao