Fenrir
Fenrir copied to clipboard
Cancel previous commit requests if selected ref changes
trafficstars
See this TODO comment: https://github.com/ForNeVeR/Fenrir/blob/f091f85b8b09cb1813cfbeb8bcbdf2870e46ad36/Fenrir/Ui/CommitsViewModel.fs#L36-L49
Consider this scenario:
- User selects a ref named
ref1 - This code block starts asynchronous load of commits for
ref1 - User quickly changes their selection to a ref named
ref2 - This code block starts another asynchronous load
- Load for
ref2my finish earlier than forref1, so data forref2will be loaded into the commit control - And later, when the asynchronous load task for
ref1is finished, it will override the contents of the commit control, which is bad!
I think about adding Rd to the mix here: if SelectedRef would be a reactive property with lifetime tracking of each value, then the implementation would be very beautiful and trivial.