tinycolor icon indicating copy to clipboard operation
tinycolor copied to clipboard

Published 20 hours ago • verified publisher icon FooStudio

upgrade to null safety

Open lslv1243 opened this issue 4 years ago • 17 comments
trafficstars

I made the required changes for the package to be sound null safe. Since it depended on Pigment which the last update was 2 years ago, to not cause any breaking change, I inlined the function that is being used. The function only parses a string as Color.

lslv1243 avatar Jan 02 '21 15:01 lslv1243

@mendieta any plans on merging and publishing the null safety version?

Curvel avatar Mar 24 '21 12:03 Curvel

Sorry, I'll merge during this week.

Cheers

mendieta avatar Mar 24 '21 13:03 mendieta

Cool. Need this.

cyberpwnn avatar Mar 27 '21 06:03 cyberpwnn

@mendieta any updates here? Would be great to get the null safety release :D

Curvel avatar Apr 06 '21 12:04 Curvel

Sorry - another request - can we merge the changes for null safety - this is the last package i need for me! thank you!!!

paulinventome avatar Apr 08 '21 08:04 paulinventome

Looking forward to this 👍

beevelop avatar Apr 12 '21 07:04 beevelop

@mendieta Guessing you're busy but any chance of merging and releasing?

JamesMcIntosh avatar Apr 21 '21 10:04 JamesMcIntosh

Merge please.

AhmedNourJamalElDin avatar Apr 28 '21 16:04 AhmedNourJamalElDin

lgtm. use of late could have been prevented, i guess..

mx1up avatar May 01 '21 13:05 mx1up

Looks like Pigment has been updated to null-safety: https://github.com/bregydoc/pigment/commit/eb95e5ea6adddf60ccb5394456eaeae17ac76c03

TNorbury avatar May 04 '21 03:05 TNorbury

@mx1up removed unnecessary late @TNorbury using Pigment again instead of copying colorFromString function

lslv1243 avatar May 04 '21 11:05 lslv1243

Please merge, thanks 😃

savadodesigns avatar May 13 '21 16:05 savadodesigns

Merge, Please

yc-codes avatar May 15 '21 11:05 yc-codes

Sorry, I'll merge during this week.

Cheers

Hi @mendieta, could you please merge :)

savadodesigns avatar May 26 '21 08:05 savadodesigns

Would love to see this merged as well! 🙏

In the meantime, I'm going to try migrating my codebase to null safety by depending on @lslv1243's latest commit in my pubspec.yaml like this:

dependencies:
  tinycolor:
    git:
      url: [email protected]:lslv1243/tinycolor.git
      ref: 87f654ce7b79daddfbe7cdf7b7d9bb27574a8b89

I haven't actually migrated yet, but running flutter pub outdated --mode=null-safety seems to indicated that this works:

❯ flutter pub outdated --mode=null-safety
Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

All your dependencies declare support for null-safety.

nfriend avatar May 29 '21 02:05 nfriend

Hey @lslv1243, can you make a PR to community-forked repo? Thanks!

calvintam236 avatar Jun 24 '21 19:06 calvintam236

Hey @lslv1243, can you make a PR to community-forked repo? Thanks!

Hey @lslv1243, please let us know if you are too busy to make the PR. We can work on it if that’s the case.

calvintam236 avatar Jul 13 '21 02:07 calvintam236