flutter_statusbar_manager icon indicating copy to clipboard operation
flutter_statusbar_manager copied to clipboard

migrate to null-safety

Open NarHakobyan opened this issue 3 years ago • 5 comments

Hi guys, I migrated package to null safety, to be honest I think this library is no more maintainable so you can use null safety version directly from git.

flutter_statusbar_manager:
  git:
    url: https://github.com/NarHakobyan/flutter_statusbar_manager
    ref: master

NarHakobyan avatar Mar 27 '21 16:03 NarHakobyan

@NarHakobyan Oops, I missed your PR and created one for this as well. I will probably close mine. I suggest limiting the arguments in the library's functions to not accept null values. Adding an link below. Also, the example app required some change to its Podfile to build. I advanced the version number and added to the changelog file, which will help the maintainers push the update.

amitkot avatar Mar 31 '21 08:03 amitkot

Hi @amitkot, yeah, it's not necessary to have nullable arguments. I have fixed it.

NarHakobyan avatar Mar 31 '21 09:03 NarHakobyan

@amitkot are you still here? :D

NarHakobyan avatar Apr 22 '21 17:04 NarHakobyan

@NarHakobyan thanks very much for your PR, I am using it for now unless something else is moving here... Do you have a solution for MissingPluginException(No implementation found for method setStyle on channel flutter_statusbar_manager) when using flutter web?

Edit: I found a solution using kIsWeb and created a PR: https://github.com/NarHakobyan/flutter_statusbar_manager/pull/1

rafaelmaeuer avatar Jun 04 '21 18:06 rafaelmaeuer

@NarHakobyan hi, missed your ping (a month ago). I'm still here, was working on other project. I'm closing my PR now.

amitkot avatar Jun 06 '21 12:06 amitkot