yomichan
yomichan copied to clipboard
FooSoft
22.9.9.0 Release
https://github.com/FooSoft/yomichan/releases/tag/22.9.9.0
General
- [x] Create release tag.
- [x] Create GitHub release.
- [x] Ensure the version is updated in the manifest.
Testing
- [x] Update Chrome testing release.
- [x] Update Firefox testing release.
- [x] Update Firefox updates.json and verify.
- [x] Upload testing builds to the GitHub release.
Stable
- [ ] Update Chrome stable release.
- [ ] Update Firefox stable release.
- [ ] Upload stable builds to the GitHub release.
(Note: I have no idea why the issue tags in the release notes are invisible)
FYI @FooSoft
Scanning seems to be much less reliable, refusing to scan for no apparent reason and sometimes refusing to scan at other times. It may have to do with the web page the content is on; things do not scan at all on Discord, and scanning is slow and only seems to work half of the time on this page. Meanwhile it's working perfectly fine here on Github.
Reverting to the previous version of the extension solves these issues. No errors in the console of the webpage or the background.html page.
Can you share your settings file, and maybe record a demo of the issues? Can you describe the "slow scanning" difference?
I am able to scan text on Discord without issue.
Problem could be related to #2176, but I'm not sure.
yomichan-settings-2022-09-10-16-38-12.zip
The slow scanning is taking multiple seconds from the cursor/modifier key being pressed to the popup showing up, and often not scanning at all. I will record a video later today.
You are on 22.6.6.0 right? I am too, but I haven't had that issue. Here are my settings yomichan-settings-2022-09-10-17-18-02.txt
I reverted after 22.9.9.0 had these scanning issues, yes. No issues on 22.6.6.0.
You can download the source code from the releases page, and install it from the 'ext' folder by loading it as an unpacked extension.
Here's a video. I'm holding down the modifier key for almost the whole time here. It seems to also suffer the same slowness in the Github text box for writing comments.
https://user-images.githubusercontent.com/17340496/189507375-657f681d-a3b9-4117-9489-a8bc3b4c165b.mp4
Can you share what it looks like with the old version? I am still unable to reproduce a speed difference between either version, although I do only have ~27 of the 50 dictionaries you have.
Not lightning quick, but very usable.
https://user-images.githubusercontent.com/17340496/189508730-7b359660-6128-46a4-a8ba-8c735aefc257.mp4
I just tried disabling all my dictionaries except JMDict and using 22.9.9.0 and the slowness persists; it noticeably speeds up lookups on 22.6.6.0. So I guess dictionary count likely isn't the issue?
Do you get the same issue with any of these versions? (Since it sounds like dictionary count isn't the issue, test with only one dictionary enabled if possible)
- https://github.com/FooSoft/yomichan/archive/310303ca1a123a77f9bd116af4dc64ad9c3256c5.zip
- https://github.com/FooSoft/yomichan/archive/0b1ad403471c0c097d08af59717a34691d8bf5b7.zip
- https://github.com/FooSoft/yomichan/archive/5c267f4bb772bb6c67576f2b40234a356c040550.zip
- https://github.com/FooSoft/yomichan/archive/c5c5308ff2addbce1f1d55dd5a8a91bbed610ee1.zip
- https://github.com/FooSoft/yomichan/archive/e7944d29b0380d46e44cc316e10a3088e9da3a8c.zip
(If you find two consecutive versions where one has the issue and one doesn't, you don't need to test the rest)
Okay, I think that confirms my suspicious that the slowness stems from the changes in #2178, although I don't see any regression on my side when profiling.
Could you test this and see if it has the issue? And if it does fix it, could you make a video comparison of 22.9.9.0 vs this one using only one dictionary?
- https://github.com/toasted-nutbread/yomichan/archive/refs/heads/css-zoom-performance-test.zip
Thank you for your help!
And thank you for the work!
Now that you mention it, it is words near the right side of the window that are slow/not being scanned. It seems to fix the issue. It also solves the scanning in Discord that wasn't working me. Glad I'm able to use 22.9.9.0 now!
Performance test:
https://user-images.githubusercontent.com/17340496/189513353-2823a848-d1bf-4699-840b-3eaea5734ffe.mp4
22.9.9.0:
https://user-images.githubusercontent.com/17340496/189513357-65a50274-3330-4442-a308-9d419ff3794d.mp4
Oh I think I see what the issue is. You might have had your zoom level on these websites at a value that isn't 100%. For some reason that will cause Chrome to report the CSS zoom level as the same as what your user-defined browser zoom is, which is not handled properly.
I'll look into fixing that properly.
ah, yep now I can't scan anything at all haha even on github
on the search page: searching by clicking on or selecting a different part of the sentence doesn't work either
my settings file is above if needed
for reference github is at 100% zoom and I have yomichan search page at 110% zoom
changing it has no effect though
@Thermospore In your OS settings, do you have display scaling set at a value other than 100%? I've found that that also triggers the issue for me. Just want to confirm the things that seem to be causing this.
@FooSoft I have bumped the release to 22.9.9.1, which includes #2227. The testing release should be updated with this, but not pushed to stable yet. There is now an option to enable/disable the relevant changes in case of issues.
Alright, @FooSoft I have made one last update for testing on this release, the main change is #2235, all changes are here. This restores support for Google Docs, which there have been some additional comments about recently so I finally got around to figuring that out.
This can go to testing for now and probably stable soon after; unless there are issues, I don't foresee any more patches necessary.
@FooSoft We can probably release to stable, I haven't seen any other issues.