yomichan-import icon indicating copy to clipboard operation
yomichan-import copied to clipboard

Various 故事ことわざの辞典 bugs

Open Thermospore opened this issue 3 years ago • 2 comments

Hello, here are some things I've noticed with the 故事ことわざの辞典 importer:

  1. There is a \n\n\n\n at the end of each definition, which should be removed
  2. I found this entry: 愛して〔も〕その悪を知り、憎みて〔も〕その善を知る. Looks like there isn't any handling for those 〔〕 brackets. I'm guessing it means you can do with or without the thing inside. Didn't check if there were other entries with this issue image
  3. Something is broken at the start of 愛縁奇縁 image image image

Thanks -Tyler

Thermospore avatar Mar 08 '21 01:03 Thermospore

@FooSoft

I think number 3 is dictionary independent. getting it with 広辞苑第六版 • 付属資料 too

current yomichan import on the left, old yomichan import on the right image

Thermospore avatar Mar 12 '21 08:03 Thermospore

Might need to create some new regex to strip away stuff in the braces. The thing with #3 is weird. I am imagining that perhaps there is a different failure mode during text decode? As you mentioned, yomichan-import has switched to zero-epwing-go for parsing; we don't have to go cross process and everything is a lot simpler in general, so that is likely cause here.

FooSoft avatar Mar 13 '21 00:03 FooSoft