EhViewer icon indicating copy to clipboard operation
EhViewer copied to clipboard

Migrate to lyricist for further CMP & Support sublocales

Open revonateB0T opened this issue 1 year ago • 7 comments

https://github.com/adrielcafe/lyricist

revonateB0T avatar Dec 10 '24 02:12 revonateB0T

For sublocale support, see https://github.com/Xed-Editor/Xed-Editor/issues/364#issuecomment-2530008512 We want to override certain translations(that we could provide) and fallback to main locale, I call it sublocale.

revonateB0T avatar Dec 10 '24 02:12 revonateB0T

Invite again. @Thisisnotgoingpublished Hi, could you translate https://github.com/FooIbar/EhViewer with that amazing tone? Due to NSFW we cannot use weblate. Btw we want to keep original Chinese translation and provide that as alternative.

revonateB0T avatar Dec 10 '24 02:12 revonateB0T

I think multiplatform resources, which are more widely supported by l10n tools (like Weblate), should be the CMP solution. #2100 is a prototype, though I'm not planning to merge that until multiplatform resources become more mature (there are still some features missing, e.g. resource shrinking) or we've done most CMP jobs. Thoughts?

FooIbar avatar Jan 27 '25 12:01 FooIbar

CMP resources have more boilerplate code in call-side comparing to lyricist, while CMP resources is supported by more editing tools like weblate, which makes it hard for me to choose. I prefer the lyricist way as there's not much translation contributors.

revonateB0T avatar Jan 28 '25 00:01 revonateB0T

CMP resources have more boilerplate code in call-side comparing to lyricist

You mean stringResource/getString? Well dropping context(Strings) here and there also feels undesirable.

FooIbar avatar Jan 28 '25 10:01 FooIbar

I'm going to revert that. Such migrations should not be merged in a half-done state, as multiple sources of truth will confuse the translators.

FooIbar avatar Feb 08 '25 02:02 FooIbar

I'm going to revert that. Such migrations should not be merged in a half-done state, as multiple sources of truth will confuse the translators.

Acked.

revonateB0T avatar Feb 08 '25 02:02 revonateB0T