EhViewer icon indicating copy to clipboard operation
EhViewer copied to clipboard

Add shared element transitions

Open FooIbar opened this issue 2 years ago • 1 comments

FooIbar avatar Apr 22 '24 14:04 FooIbar

https://issuetracker.google.com/issues/336449371

revonateB0T avatar Apr 23 '24 14:04 revonateB0T

Wow, seems both SET within navigations and downloadScreen grid/list switch works perfectly!

revonateB0T avatar Jul 25 '24 14:07 revonateB0T

Btw, my telegram account gone again, and maybe I won't register a new one in a long time.

revonateB0T avatar Jul 25 '24 14:07 revonateB0T

Is there anything blocking we land this?

revonateB0T avatar Jul 28 '24 12:07 revonateB0T

Is there anything blocking we land this?

Haven't got time to look at this

FooIbar avatar Jul 28 '24 12:07 FooIbar

Everything looks good, seems we don't need https://issuetracker.google.com/issues/336449371?

FooIbar avatar Jul 28 '24 13:07 FooIbar

Everything looks good, seems we don't need https://issuetracker.google.com/issues/336449371?

Yeah, could you help test if that snippet still behaves incorrectly?

revonateB0T avatar Jul 28 '24 13:07 revonateB0T

Everything looks good, seems we don't need https://issuetracker.google.com/issues/336449371?

Yeah, could you help test if that snippet still behaves incorrectly?

Yes, the issue persists.

FooIbar avatar Jul 28 '24 14:07 FooIbar

Everything looks good, seems we don't need https://issuetracker.google.com/issues/336449371?

Yeah, could you help test if that snippet still behaves incorrectly?

Yes, the issue persists.

Acked.

revonateB0T avatar Jul 28 '24 14:07 revonateB0T

@revonateB0T I think we may only want shared element transitions for list <=> detail. The list <=> list and list <=> grid transitions feel distracting as there are too many moving parts. Like the M3 guide says https://m3.material.io/styles/motion/transitions/applying-transitions#b974d94c-bf80-4c54-8818-4a1d7eaa10ae

FooIbar avatar Aug 03 '24 10:08 FooIbar

@revonateB0T I think we may only want shared element transitions for list <=> detail. The list <=> list and list <=> grid transitions feel distracting as there are too many moving parts. Like the M3 guide says https://m3.material.io/styles/motion/transitions/applying-transitions#b974d94c-bf80-4c54-8818-4a1d7eaa10ae

Well, maybe, list <=> grid is somewhat lag as there's so many moving items. But I suppose the multiple SET framework can be kept in case it's useful and we may need it one day.

revonateB0T avatar Aug 03 '24 10:08 revonateB0T