default_value_for icon indicating copy to clipboard operation
default_value_for copied to clipboard

Published 20 hours ago • verified publisher icon FooBarWidget

Support rails 7.0

Open KevSlashNull opened this issue 3 years ago • 5 comments

This adds support for the recently released Rails 7.0.

KevSlashNull avatar Jan 06 '22 17:01 KevSlashNull

Any update on this?

benguillet avatar Mar 24 '22 20:03 benguillet

I think this is ready, isn’t it, @bfad? I’m busy right now but I can run the tests against 6.1.4.4 tomorrow but I thought they were passing now.

KevSlashNull avatar Mar 24 '22 20:03 KevSlashNull

It looks like the tests are passing with 6.1.5 for me.

bfad avatar Mar 25 '22 17:03 bfad

Bumping this 🙏

nbcraft avatar May 13 '22 00:05 nbcraft

@bfad, yeah, tests are passing for 6.1.5, 6.1.6, and 7.0.3 for me. Sorry for the late response.

KevSlashNull avatar May 13 '22 19:05 KevSlashNull

Bump, can this be merged? 🙏

NEWeber avatar Aug 05 '22 21:08 NEWeber

@chrisarcand Can you merge this?

seanarnold avatar Aug 09 '22 21:08 seanarnold

+1

paulschreiber avatar Aug 10 '22 01:08 paulschreiber

@bfad, this PR has been tested and approved, who's the best person with write access to ask to merge it?

Thanks!

NEWeber avatar Aug 12 '22 16:08 NEWeber

/cc @FooBarWidget

KevSlashNull avatar Aug 12 '22 17:08 KevSlashNull

Hey @norman, this PR needs merged to support Rails 7: it's been tested and approved by Brad.

Would appreciate this being merged, Kev's done the hard work on it and Brad has approved it.

If you're not the go-to guy for this, would you please poke the person who is? We've already @'d a bunch of the major contributors here.

Thank you! 🙏

NEWeber avatar Aug 17 '22 14:08 NEWeber

Thanks everybody for working on this. I haven't been actively maintaining this library for a few years now, but it looks like I still have all the permissions to do the release. I'll look things over today and see about merging and releasing.

norman avatar Aug 17 '22 14:08 norman

Actually wait, if I recall correctly we might require @FooBarWidget's cryptographic signature to push the gem. I'll look into it and get as far as I can.

norman avatar Aug 17 '22 14:08 norman

These changes look good to me and I so I merged them into the master branch. I was unable to run the tests because of safe_load errors with Psych, and don't have time to look into this today. If I can't even run the specs, then I'm not comfortable pushing a release out. If I can find the time I'll look into this later, but I didn't plan to maintain this library any more since I haven't used it for a long time.

For folks that need to use this release, I'd suggest setting up your application Gemfiles to load the gem from the master branch on Github for the time being.

norman avatar Aug 17 '22 15:08 norman

@norman the tests work fine in my environment. Have you tried since August to run these? Screen Shot 2022-11-08 at 3 56 53 PM

seanarnold avatar Nov 08 '22 02:11 seanarnold