fah-control
fah-control copied to clipboard
fix PEP8 errors, move to python3
Hi there, I think we should move to python 3, right now I can't make this work on fedora 31/32 because it's only python 2. The default python in fedora (and most other linux distributions) is python3 and I suppose that on windows and mac it's mostly the same. I mention this because I saw there are some work on this but it didn't mature yet.
I started working on migrating the code to python3 and saw that at least some of the code is not PEP8 compliant, so 2 questions:
- If I fix all the PEP8 stuff, is it something you want merged?
- Once I finish the work to migrate all the code to python3 (or chunks of it, as long as it works well with python2 too), should I do a pull request?
- Which versions of python3 should be supported? I suppose all the new versions, but what is the oldest we want to support? (for example, can I use f strings, which was introduced on python 3.6?)
I can make sure it works on python3 since I have python 3.8 on my machine, will see how to make sure if relevant if it works on python2
I have here 2 things, one is the PEP8 and the other is python 2to3, so if you want I can split this to 2 issues if wanted
@moshe742 did you review the two python 3 ports on the PR list? You may ask those efforts to be PEP8 compliant.
Are the open PR's still active? Looks like there hasn't been activity for about a month. Would be happy to help get them over the finish line.
@alexottoboni what do you mean as "active"? The work is done, just waiting for upstream to pick it up.