FocusLuo

Results 9 comments of FocusLuo

[vpp_clips.zip](https://github.com/01org/libyami/files/1161085/vpp_clips.zip)

ffmpeg-qsv cmdline: ./smoke run test/ffmpeg-qsv/encode --pl DG2 --context=sanity --device=/dev/dri/renderD129 -vv ./smoke run test/ffmpeg-qsv/encode --pl DG2 --context=sanity --device=/dev/dri/renderD129 --stringapi 0 -vv ./smoke run test/ffmpeg-qsv/encode --pl DG2 --context=sanity --device=/dev/dri/renderD129 --stringapi 1 -vv...

> This is not a full review... > > I'm not convinced we should modify the base qsv encoder. It seems we could introduce a new qsv string encoder class...

> > > This is not a full review... > > > I'm not convinced we should modify the base qsv encoder. It seems we could introduce a new qsv...

New test cases cmdlines: for avc/hevc/av1 encode ./smoke run test/ffmpeg-qsv/encode/hevc.py:cqp.test_strapi --pl ADL --context=sanity --device=/dev/dri/renderD128 -vv ./smoke run test/ffmpeg-qsv/encode/hevc.py:cqp_lp.test_strapi --pl DG2--context=sanity --device=/dev/dri/renderD129 -vv ./smoke run test/ffmpeg-qsv/encode/hevc.py:cbr.test_strapi --pl ADL --context=sanity --device=/dev/dri/renderD128 -vv...

@uartie do you think it is good to merge this PR firstly? then let me to submit another PR for your other comments such as 1) move map_level/rate/profile to the...

> > @uartie do you think it is good to merge this PR firstly? then let me to submit another PR for your other comments such as > > >...

@uartie is the latest new update version good to you?

> The end result looks good to me. > > However, please squash your commits into a few logically organized commits, as appropriate. There should not be any intermediate commits...