RyzenAdj icon indicating copy to clipboard operation
RyzenAdj copied to clipboard

build instructions are not robust enough

Open diggit opened this issue 1 year ago • 2 comments

Hi, build instructions in readme assume the default cmake build backend is make which may not be the case (in my case it's Ninja which is faster than make).

Original

cd RyzenAdj
rm -r win32
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
make
#...

Suggested

cd RyzenAdj
rm -r win32
cmake -B build -S . -DCMAKE_BUILD_TYPE=Release
cmake --build build
cd build
#...

What do you think?

Edit: fixed cmake args (upper case)

diggit avatar Oct 27 '24 21:10 diggit

I decided to try this on Mint 22. At the first cmake I got:

CMake Warning:
  Ignoring extra path from command line:

   "[my full path to]/RyzenAdj/build"


CMake Error: Unknown argument -s
CMake Error: Run 'cmake --help' for all supported options.

Ken-g6 avatar Dec 07 '24 03:12 Ken-g6

@Ken-g6 sorry for that, I wrote this issue in hurry and forgot the correct case of arguments (upper case), fixed it now.

diggit avatar Dec 07 '24 09:12 diggit