model-zoo icon indicating copy to clipboard operation
model-zoo copied to clipboard

Published 20 hours ago • verified publisher icon FluxML

'matchall' is depreciated

Open NTimmons opened this issue 6 years ago • 4 comments

The example 'model-zoo/text/lang-detection/' uses matchall and that is depreciated in Julia 1.0

NTimmons avatar Nov 02 '18 20:11 NTimmons

I guess this model slipped through the net when we were upgrading to 1.0. A patch would be great if you're able to upgrade it.

MikeInnes avatar Nov 05 '18 12:11 MikeInnes

Would love to. I will have a bash at it

NTimmons avatar Nov 06 '18 09:11 NTimmons

Changes in Pull Request #71

NTimmons avatar Nov 06 '18 16:11 NTimmons

I had these problems too and started fixing straightforward things (like using Unicode, Statistics, and Random) but ran into a stack overflow and found this after checking the issues.

So this model still doesn't work but I think you guys know this already?

Checking the pull request(s)...

zot avatar Sep 14 '19 21:09 zot