model-zoo icon indicating copy to clipboard operation
model-zoo copied to clipboard

Added Condtional GAN and DCGAN tutorial

Open shreyas-kowshik opened this issue 6 years ago • 6 comments

Added the markdown file as discussed @MikeInnes

shreyas-kowshik avatar Mar 04 '19 06:03 shreyas-kowshik

The cGAN part code is completed. Will add the tutorial in the Literate.jl format next.

shreyas-kowshik avatar Mar 04 '19 21:03 shreyas-kowshik

Ping @MikeInnes. Updated PR with 2 tutorials in the format as discussed.

shreyas-kowshik avatar Mar 04 '19 22:03 shreyas-kowshik

Could we get rid of the .ipynb_checkpoints really quickly?

DhairyaLGandhi avatar Mar 19 '19 11:03 DhairyaLGandhi

Thank you @dhairyagandhi96 . I have made the changes requested.

shreyas-kowshik avatar Mar 19 '19 13:03 shreyas-kowshik

You shouldn't have the same content twice here, you can remove the generated markdown file. Not sure what I asked for earlier (ideal to reference comments) but a README would usually just have an overall description and instructions for running the script.

MikeInnes avatar Mar 25 '19 14:03 MikeInnes

@MikeInnes Thank You for the feedback. I have removed the shortened the content of the markdown files, removed HTML and fancy formatting and added instructions to run the script.

shreyas-kowshik avatar Mar 25 '19 19:03 shreyas-kowshik