Zygote.jl icon indicating copy to clipboard operation
Zygote.jl copied to clipboard

Use PythonCall instead of PyCall for tests

Open ToucheSir opened this issue 1 year ago • 2 comments

The former has caused and still continues to cause us some grief on CI. With more and more packages migrating to PythonCall and us not actually using it in Zygote's own source, I don't see much harm in doing this.

ToucheSir avatar Mar 30 '23 15:03 ToucheSir

@ToucheSir Hello sir, I am interested to solve this issue, can you please elaborate what I need to actually do here. I see this is related to writing some test cases, but I am still not sure.

Jay-sanjay avatar Oct 23 '23 08:10 Jay-sanjay

We have an existing test set at https://github.com/FluxML/Zygote.jl/blob/f7551273080569316f5127cc6a537b62ef50f592/test/features.jl#L688-L698 which uses PyCall.jl. The goal would be to replace it with PythonCall.jl while keeping the code as close as possible to the original. Same function definition and rule, same inputs, etc.

ToucheSir avatar Oct 24 '23 19:10 ToucheSir