Zygote.jl icon indicating copy to clipboard operation
Zygote.jl copied to clipboard

Published 20 hours ago • verified publisher icon FluxML

test with ChainRulesTestUtils

Open CarloLucibello opened this issue 4 years ago • 2 comments

we should replace out testing utilities https://github.com/FluxML/Zygote.jl/blob/master/test/gradcheck.jl

with the ones given by ChainRulesTestUtils. https://juliadiff.org/ChainRulesTestUtils.jl/dev/#Testing-AD-systems

CarloLucibello avatar Jul 28 '21 12:07 CarloLucibello

Maybe. There's something to be said for keeping legacy tests as they were, so that you can be quite sure what's changed if they fail. And, if spending time re-writing things, perhaps it's better spend on transferring rules to ChainRules, & adding upgraded tests there.

mcabbott avatar Aug 01 '21 01:08 mcabbott

Now that we are free of Zygote-isms in src/ and upstreamed as many rules as we can to ChainRules (in Flux, Zygote is still a WIP), perhaps it's time to revisit this.

ToucheSir avatar Jun 15 '22 03:06 ToucheSir