Allow loading custom weights files for EfficientNet

Open IanButterworth opened this issue 2 years ago • 2 comments

Intends to make it possible to load custom pretrained EfficientNet models.

Opening this PR as a draft to see if there are opinions as I am unfamiliar with this package.

PR Checklist

[ ] Tests are added
[ ] Documentation, if applicable

Dec 04 '23 17:12 IanButterworth

This generally makes sense to me, can you think of any way taking a string path could limit us further down the line @darsnack @theabhirath ?

Dec 05 '23 15:12 ToucheSir

There was a plan to open up the pretrain argument to allow specifying the name of an artifact to load. The intention being to have multiple artifacts per model spec.

But I think the way this is implemented, it should be easy to add that case down the line. Looks good to me! I guess the only suggestion is to add this feature to other models as well for consistency.

Dec 05 '23 16:12 darsnack