IRTools.jl icon indicating copy to clipboard operation
IRTools.jl copied to clipboard

Calling SSAValues `var` and "variables" is confusing

Open oxinabox opened this issue 6 years ago • 2 comments

When I saw "variables" in the docs, As in:

The IR can be viewed as a mapping from variables to statements, and indexing and iteration are consistent with that.

I assumed it was talking about slots. But it isn't, it is talking about SSAValue. (and SSAValues never vary)

oxinabox avatar Apr 20 '19 12:04 oxinabox

They are variables in the same sense that variables in mathematics or functional languages are; they are placeholders which take on different values between invocations. If there's a better name we could switch to that, or perhaps just define this clearly, if we're not already.

MikeInnes avatar Apr 24 '19 12:04 MikeInnes

Are slots, also variables?

If not, SSAVars, SingleAssigmentVariables, StatementValues.

I like StatementValues.

oxinabox avatar Apr 24 '19 13:04 oxinabox