Flux.jl icon indicating copy to clipboard operation
Flux.jl copied to clipboard

Training mod: using ProgressMeter.jl in `train!`

Open XWHtorrentx opened this issue 2 years ago • 3 comments

Add a progress bar with display of training loss in train!(...). For training less than 1 batch there is no display of progress bar and training loss.

XWHtorrentx avatar Apr 25 '22 09:04 XWHtorrentx

Thanks for this contribution!

If I understand this correctly, this specifically uses ProgressMeter.jl as the front end for progress logging? Our current approach uses ProgressLogging.jl with integrates with VS Code and offers a choice of front ends. One advantage to ProgressMeter.jl is the ability to print the speed for infinite length sequences. We would need to discuss whether this is worth the change.

darsnack avatar Apr 25 '22 13:04 darsnack

We should not be using this library, but a docs PR mentioning https://github.com/JuliaLogging/TerminalLoggers.jl would be fine.

ToucheSir avatar Apr 25 '22 13:04 ToucheSir

Codecov Report

Merging #1954 (78071e8) into master (261efb1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   87.72%   87.73%   +0.01%     
==========================================
  Files          19       19              
  Lines        1458     1460       +2     
==========================================
+ Hits         1279     1281       +2     
  Misses        179      179              
Impacted Files Coverage Δ
src/optimise/train.jl 94.28% <100.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 261efb1...78071e8. Read the comment docs.

codecov-commenter avatar Apr 25 '22 14:04 codecov-commenter