Typescript Migration complete.

[iamsethsamuel]

The Javascript Version is working as before and the Typescript version with all the type are working

There is a new way to import packages that takes full advantage of Typescript

import RaveBase from "flutterwave-node-v3/lib/rave.base";
import Settlements from "flutterwave-node-v3/lib/rave.settlements";


const rave = new RaveBase(process.env.PUBLIC_KEY!, process.env.SECRET_KEY!)
//Rave in now pass to the Settlements constructor
const settlements = new Settlements(rave)

 settlements.fetch_all().then(res=>{
    const data = res.data
    console.log(data)
    for(const d of res.data){
        console.log(d.channel,d.app_fee, d.currency,)

    }
})

This new method allows for tree shaking the package.

I just pray this gets merged

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	fe9ca701cc7e6c2aac2899d57e5da12e13dc20a3	services/tokenized-charges/rave.bulk.charge.js	View secret
-	Generic High Entropy Secret	fe9ca701cc7e6c2aac2899d57e5da12e13dc20a3	services/tokenized-charges/rave.bulk.charge.js	View secret
-	Generic High Entropy Secret	fe9ca701cc7e6c2aac2899d57e5da12e13dc20a3	services/tokenized-charges/rave.bulk.charge.ts	View secret
-	Generic High Entropy Secret	fe9ca701cc7e6c2aac2899d57e5da12e13dc20a3	services/tokenized-charges/rave.bulk.charge.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[orimdominic]

Good day @corneliusyaovi

Is there any reason why this has not been merged yet? Is there any contribution that we can make to make this process faster?

[alob-mtc]

Hello @orimdominic @iamsethsamuel this is a fairly large PR and the move to TS if at all needs to be by increment, also it would be better to raise an issue first for discussion for a change this significant before raising a PR to avoid the risk of rejection. I hope this helps

[iamsethsamuel]

Hello @orimdominic @iamsethsamuel this is a fairly large PR and the move to TS if at all needs to be by increment, also it would be better to raise an issue first for discussion for a change this significant before raising a PR to avoid the risk of rejection. I hope this helps

It was raised before it was worked upon

[alob-mtc]

Hello @orimdominic @iamsethsamuel this is a fairly large PR and the move to TS if at all needs to be by increment, also it would be better to raise an issue first for discussion for a change this significant before raising a PR to avoid the risk of rejection. I hope this helps

It was raised before it was worked upon

Thanks for the clarification, please link the issue in the PR for easy tracking

[alob-mtc]

I would really like to see this merge, but at quick glance i see a lot of file changes that don't related to Typescript port, this will make it a lot harder to get this PR merged

[iamsethsamuel]

I would really like to see this merge, but at quick glance i see a lot of file changes that don't related to Typescript port, this will make it a lot harder to get this PR merged

First of can you merge the PR? if yes, then we can work on it to be merged

[orimdominic]

On the Flutterwave channel, @corneliusyaovi had already said that this would be worked on later this year because of the other products being focused on