flux icon indicating copy to clipboard operation
flux copied to clipboard

[BUGFIX] Use page layout specific column labels

Open cweiske opened this issue 3 years ago • 3 comments

Labels of columns in page layouts were only translatable with the generic non-specific key "flux.grid.columns.$columnName".

This patch sets the page layout's grid parent object to be the page layout's form, so that the resolved parent ID is that of the form.

A column named "one" within a page layout with id "twocol" will thus get the label key "flux.twocol.columns.one", just as it was for flux 8.

Resolves: https://github.com/FluidTYPO3/flux/issues/1468


:warning: I only found the code that fixes #1468. Because of the complexity of flux and my limited experience, I have no idea if that change breaks something else.

cweiske avatar Jan 25 '22 09:01 cweiske

:x: This patch breaks backend layout selection in the page settings on TYPO3 v10 without fluidpages, while it worked fine on v8 with fluidpages. When using this flux patch together with the test_provider_extension, selecting the page layout "Other Template" or "Page template in sub-folder" leads to an error:

An error occurred trying to process items for field "Backend Layout (this page only)" (Parameter $extensionName cannot be empty if a fully-qualified key is not specified.).

Adding the "extensionName" property to the page layout's <form> tag does not help.

cweiske avatar Jan 27 '22 10:01 cweiske

The TYPO3 v10 problem is fixed now.

cweiske avatar Jan 27 '22 14:01 cweiske

Works fine on TYPO 9 and 10.

cweiske avatar May 20 '22 11:05 cweiske