Haiku port
It seems we had patches getting dust. I rebased them and dropped stuff that didn't seem needed anymore. All tests pass though I haven't tried the audio or MIDI outputs, but the code worked in previous versions.
Ugh, seems they missed the proper Haiku check :shrug:
That should fix it.
For some reason tests 25 & 27 fail now… !?
Oh, yeah… nothing LANC=C LC_ALL=C can't fix. (comma vs decimal point)
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Thanks for submitting. However, this is not yet in a shape that is ready to accept. It needs some work. Comments below.
Well I didn't write most of this code, just trying to upstream before it bit-rots, so I'll have to figure it out as well.
Also, it would be very helpful to have a Haiku CI build in place, to avoid breaking stuff in the future. Edit: Here's an example of how SDL coped with Haiku CI: libsdl-org/SDL#6739
Yes, though our cross-compiler is only built as part of our build system, but there are a few solutions now.
poke @Cacodemon345 @threedeyes :-)
I can't directly push to the branch (and I don't have a working Haiku OS installation at the moment either at the moment to help out with the changes).
This PR has been open for several months, but unfortunately, nobody has showed interest to contribute. For the record, if someone is willing to use fluidsynth on Haiku, pls. address the points I brought up above and re-file a PR.
It's more lack of time than lack of interest really.
Understood. Yet, I cannot keep this open forever. As said, feel free to re-file a PR.