media-ui icon indicating copy to clipboard operation
media-ui copied to clipboard

FEATURE: upload dialog with configurable additional property fields

Open andrehoffmann30 opened this issue 3 years ago • 5 comments

What I did I adjusted the upload dialog. It is now possible to configure additonal property filed sto collect the information while uploading a news file. The new new upload dialog is used in the backend module and ind the content area.

How I did it For the backend module I adjusted the existing upload dialog to respect the new configuration options and handel the rendering and file upload logic accordinglly. For the Content area i added a MediaUploadScreen as a scondary editor to render and handle the file upload like in the bakcend module. For thsi to function also an adjustment of the image editor is needed (see https://github.com/neos/neos-ui/pull/3302 ).

How to verify it Configure the fileds according to the example in the read me, than the uplaod dialog should render the new additional fields and bahave as configured.

image

andrehoffmann30 avatar Dec 20 '22 10:12 andrehoffmann30

Hallo @Sebobo, thank you very much for your feedback. I adjust some of my changes and left additional explanations to your comments. Feel free to give me further feedback. Thank you.

andrehoffmann30 avatar Nov 20 '23 15:11 andrehoffmann30

Hi Andre, thx! Will take me some days again to go through things :)

Sebobo avatar Nov 22 '23 07:11 Sebobo

Hi @Sebobo I adjusted the components and styling as you suggested. I only committed my code changes, but no builds to not further increase the size of my pr unnecessarily. I also did not rebase to the latest main. Please take a look at the changes and let me know, if there are still problems. Please contact me as soon as you are ready to merge my changes, so that I can rebase my branch. Please also contact me if you have any further questions. Thank you very much.

andrehoffmann30 avatar Feb 19 '24 11:02 andrehoffmann30

@andrehoffmann30 thank your! I plan to review again end of this week or start of next.

Sebobo avatar Feb 20 '24 08:02 Sebobo

Hi @Sebobo , have you had time to check my latest adjustments? Please let me know if I can help you in any way. Thank you.

andrehoffmann30 avatar Mar 18 '24 09:03 andrehoffmann30