Flowpack.NodeTemplates icon indicating copy to clipboard operation
Flowpack.NodeTemplates copied to clipboard

Published 20 hours ago • verified publisher icon Flowpack

FEATURE: Deprecated `triggeringNode` in favour of `site` and `sourceParentNode`

Open mhsdesign opened this issue 2 years ago • 2 comments

Introduce parentNode as reference to the parent of the node the template is initially applied on. The parent of the outermost node the Neos UI creates.

We should wait with merging this, as parentNode meant something else in V1, and was breaking removed in V2.

mhsdesign avatar Jun 24 '23 13:06 mhsdesign

So is this PR now breaking or what should we wait for?

Sebobo avatar Jun 30 '23 06:06 Sebobo

No its just unexpected, but then again when migrating from v 1.x its not less unexpected that parentNode will be null, so we might as well give it already new purpose with 2.1

I added a warning in the readme ;)

Warning The behaviour of parentNode changed from version 1.x to 2.x

mhsdesign avatar Jul 04 '23 06:07 mhsdesign

As discussed in todays weekly with christian and paula, we concluded that parentNode and site are good new variables. The confusion as parentNode existed beforehand with different meaning should be minimal and will be documented. Version 2 is out since 1 year so enough time has passed for us to make such behaviour change. Also as parentNode doesnt exist in 2.0 yet this can be perfectly legal released as minor change.

https://github.com/Flowpack/Flowpack.NodeTemplates/pull/70#discussion_r1648764876

mhsdesign avatar Jun 21 '24 11:06 mhsdesign