Flowpack.ElasticSearch.ContentRepositoryAdaptor icon indicating copy to clipboard operation
Flowpack.ElasticSearch.ContentRepositoryAdaptor copied to clipboard

Published 20 hours ago • verified publisher icon Flowpack

BUGFIX: ElasticSearchQueryBuilder removes json encode generated quotes

Open gjwnc opened this issue 2 years ago • 1 comments

By default the ES CR Adaptor uses query_string which allows some search syntax in query string.

In the current implementation, json_encode is used on the query string which adds double quotes around the search term, e.g. brown fox is json encoded to "brown fox". Then trim is used to remove the ".

Since one can use double quotes in the search term itself, e.g. quick "brown fox" this results in json encoded "quick \"brown fox\"". If you use trim you get invalid json which causes an exception because of invalid syntax in the ES query: quick \"brown fox\.

This PR, just removes the outer quotes created by json_encode.

gjwnc avatar Dec 06 '22 08:12 gjwnc

I just noticed, that this issues is mentioned here #311 . Since, it could depend on the use case, both PR's might be considered independent.

gjwnc avatar Dec 06 '22 10:12 gjwnc