FlowKit icon indicating copy to clipboard operation
FlowKit copied to clipboard

Use 'SELECT DISTINCT ON' in LastLocation

Open jc-harrison opened this issue 1 year ago • 1 comments

Closes #6603

I have:

  • [x] Formatted any Python files with black
  • [x] Brought the branch up to date with master
  • [x] Added any relevant Github labels
  • [ ] Added tests for any new additions
  • [ ] Added or updated any relevant documentation
  • [ ] Added an Architectural Decision Record (ADR), if appropriate
  • [ ] Added an MPLv2 License Header if appropriate
  • [ ] Updated the Changelog

Description

Rewrites the SQL for LastLocation to use SELECT DISTINCT ON instead of a window function.

jc-harrison avatar May 22 '24 15:05 jc-harrison

Acceptance tests for generated sql need updating

greenape avatar May 24 '24 11:05 greenape

Passing run #22810 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into faster-last-location
Project: FlowAuth Commit: 746c9faf28
Status: Passed Duration: 00:43 💡
Started: Jun 12, 2024 9:04 AM Ended: Jun 12, 2024 9:05 AM

Review all test suite changes for PR #6622 ↗︎

cypress[bot] avatar Jun 11 '24 09:06 cypress[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.31%. Comparing base (582139d) to head (3acdac7).

:exclamation: Current head 3acdac7 differs from pull request most recent head 746c9fa

Please upload reports for the commit 746c9fa to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6622   +/-   ##
=======================================
  Coverage   92.30%   92.31%           
=======================================
  Files         268      268           
  Lines       10586    10586           
  Branches      855      855           
=======================================
+ Hits         9771     9772    +1     
  Misses        676      676           
+ Partials      139      138    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 11:06 codecov[bot]