FlowKit
FlowKit copied to clipboard
Use 'SELECT DISTINCT ON' in LastLocation
Closes #6603
I have:
- [x] Formatted any Python files with black
- [x] Brought the branch up to date with master
- [x] Added any relevant Github labels
- [ ] Added tests for any new additions
- [ ] Added or updated any relevant documentation
- [ ] Added an Architectural Decision Record (ADR), if appropriate
- [ ] Added an MPLv2 License Header if appropriate
- [ ] Updated the Changelog
Description
Rewrites the SQL for LastLocation to use SELECT DISTINCT ON instead of a window function.
Acceptance tests for generated sql need updating
Passing run #22810 ↗︎
Details:
| Merge branch 'master' into faster-last-location | |||
| Project: FlowAuth | Commit: 746c9faf28 |
||
| Status: Passed | Duration: 00:43 💡 | ||
| Started: Jun 12, 2024 9:04 AM | Ended: Jun 12, 2024 9:05 AM | ||
Review all test suite changes for PR #6622 ↗︎
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.31%. Comparing base (
582139d) to head (3acdac7).
:exclamation: Current head 3acdac7 differs from pull request most recent head 746c9fa
Please upload reports for the commit 746c9fa to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #6622 +/- ##
=======================================
Coverage 92.30% 92.31%
=======================================
Files 268 268
Lines 10586 10586
Branches 855 855
=======================================
+ Hits 9771 9772 +1
Misses 676 676
+ Partials 139 138 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.