FlowKit icon indicating copy to clipboard operation
FlowKit copied to clipboard

Json logs

Open greenape opened this issue 1 year ago • 2 comments

I have:

  • [x] Formatted any Python files with black
  • [x] Brought the branch up to date with master
  • [x] Added any relevant Github labels
  • [ ] Added tests for any new additions
  • [ ] Added or updated any relevant documentation
  • [ ] Added an Architectural Decision Record (ADR), if appropriate
  • [ ] Added an MPLv2 License Header if appropriate
  • [x] Updated the Changelog

Description

Adds a new env var, FLOWDB_LOG_DEST which controls the log destination config item, and changes the default to json files.

greenape avatar May 15 '24 12:05 greenape

1 failed and 2 flaky tests on run #22873 ↗︎

1 36 0 6 Flakiness 2

Details:

Merge branch 'master' into json-logs
Project: FlowAuth Commit: ea0c5779b2
Status: Failed Duration: 02:11 💡
Started: Jun 14, 2024 8:32 PM Ended: Jun 14, 2024 8:34 PM
Failed  cypress/e2e/role_list.js • 1 failed test

View Output

Test Artifacts
role list screen > Add blank role Test Replay Screenshots
Flakiness  cypress/e2e/add_new_server.js • 2 flaky tests

View Output

Test Artifacts
Server management > Add duplicate Server name Test Replay Screenshots
Server management > Add server Test Replay Screenshots

Review all test suite changes for PR #6600 ↗︎

cypress[bot] avatar May 15 '24 13:05 cypress[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.30%. Comparing base (4ae810e) to head (36a3320).

:exclamation: Current head 36a3320 differs from pull request most recent head ea0c577

Please upload reports for the commit ea0c577 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6600   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         268      268           
  Lines       10590    10590           
  Branches      856      856           
=======================================
  Hits         9775     9775           
  Misses        676      676           
  Partials      139      139           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 13:05 codecov[bot]