FlowKit icon indicating copy to clipboard operation
FlowKit copied to clipboard

Bump deps

Open jc-harrison opened this issue 3 years ago • 3 comments

I have:

  • [ ] Formatted any Python files with black
  • [ ] Brought the branch up to date with master
  • [ ] Added any relevant Github labels
  • [ ] Added tests for any new additions
  • [ ] Added or updated any relevant documentation
  • [ ] Added an Architectural Decision Record (ADR), if appropriate
  • [ ] Added an MPLv2 License Header if appropriate
  • [ ] Updated the Changelog

Description

  • Re-lock all Pipfiles
  • Bump Apache Airflow to 2.3.4
  • Downgrade FlowETL base airflow image to 2.3.4 (for consistency with flowetl Pipfile)
  • Configure dependabot to ignore airflow version in Dockerfile

jc-harrison avatar Sep 20 '22 09:09 jc-harrison



Test summary

43 0 0 0Flakiness 0


Run details

Project FlowAuth
Status Passed
Commit 37c52acf5d
Started Nov 4, 2022 1:03 PM
Ended Nov 4, 2022 1:14 PM
Duration 10:57 💡
OS Linux Debian - 10.5
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 20 '22 09:09 cypress[bot]

Currently hitting a number of issues, none of which I've managed to diagnose yet:

  • In flowetl integration tests, airflow is complaining about needing to run 'airflow db upgrade' (on what should be an empty or newly-initialised db). I initially thought this was related to psycopg2 issues that arose in airflow 2.4.0 (apache-airflow-providers-postgres 5.2.1), which is why I've only bumped airflow to 2.3.4, but the issue remains so perhaps once it's resolved we'll be able to upgrade to airflow 2.4.0 after all.
  • When building the docs, example notebooks are complaining that TOKEN is undefined - implies the notebook_preamble.py script is not running.
  • FlowAPI is returning a 500 error instead of the API spec

jc-harrison avatar Sep 21 '22 17:09 jc-harrison

This is nearly there, but seems to be timing out in the flowetl integration tests.

greenape avatar Oct 21 '22 12:10 greenape

Codecov Report

Merging #5464 (84db397) into master (7483ffd) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 84db397 differs from pull request most recent head 37c52ac. Consider uploading reports for the commit 37c52ac to get more accurate results

@@           Coverage Diff           @@
##           master    #5464   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         269      269           
  Lines       10284    10284           
  Branches     1276     1276           
=======================================
  Hits         9656     9656           
  Misses        491      491           
  Partials      137      137           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 03 '22 17:11 codecov[bot]