Exposing PerSubscriberAggregate
Closes #4581
I have:
- [x] Formatted any Python files with black
- [x] Brought the branch up to date with master
- [x] Added any relevant Github labels
- [ ] Added tests for any new additions
- [ ] Added or updated any relevant documentation
- [ ] Added an Architectural Decision Record (ADR), if appropriate
- [x] Added an MPLv2 License Header if appropriate
- [ ] Updated the Changelog
Description
Exposing PerSubscriberAggregate
Test summary
Run details
| Project | FlowAuth |
| Status | Passed |
| Commit | b12e04c6e9 |
| Started | Nov 24, 2021 11:57 AM |
| Ended | Nov 24, 2021 12:02 PM |
| Duration | 05:40 💡 |
| OS | Linux Debian - 10.5 |
| Browser | Electron 94 |
View run in Cypress Dashboard ➡️
Flakiness
|
|
cypress/integration/add_new_server.js |
1 |
|
|---|---|---|---|
| 1 | Server management > Add server |
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Codecov Report
Merging #4590 (ef90f5f) into master (d869364) will decrease coverage by
0.17%. The diff coverage is5.00%.
:exclamation: Current head ef90f5f differs from pull request most recent head 0ae659e. Consider uploading reports for the commit 0ae659e to get more accurate results
@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
- Coverage 93.42% 93.25% -0.18%
==========================================
Files 262 263 +1
Lines 10356 10376 +20
Branches 895 896 +1
==========================================
+ Hits 9675 9676 +1
- Misses 549 568 +19
Partials 132 132
| Flag | Coverage Δ | |
|---|---|---|
| autoflow_unit_tests | 93.03% <ø> (ø) |
|
| flowapi_unit_tests | 72.76% <ø> (ø) |
|
| flowauth_unit_tests | 78.41% <ø> (ø) |
|
| flowclient_unit_tests | 74.65% <50.00%> (-0.08%) |
:arrow_down: |
| flowetl_unit_tests | 95.49% <ø> (ø) |
|
| flowkit_jwt_generator_unit_tests | 95.10% <ø> (ø) |
|
| flowmachine_unit_tests | 90.53% <0.00%> (-0.24%) |
:arrow_down: |
| integration_tests | 66.04% <5.00%> (-0.14%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...e/server/query_schemas/per_subscriber_aggregate.py | 0.00% <0.00%> (ø) |
|
| flowclient/flowclient/aggregates.py | 94.89% <50.00%> (-0.94%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d869364...0ae659e. Read the comment docs.
Is this still alive, or would it need to be reworked now?
Is this still alive, or would it need to be reworked now?
Would need to be reworked a bit, to use OneOfQuerySchema, but I don't think there are any fundamental changes required.