FlowKit icon indicating copy to clipboard operation
FlowKit copied to clipboard

Clean shutdown

Open greenape opened this issue 4 years ago • 3 comments

Closes #4053

I have:

  • [ ] Formatted any Python files with black
  • [ ] Brought the branch up to date with master
  • [ ] Added any relevant Github labels
  • [ ] Added tests for any new additions
  • [ ] Added or updated any relevant documentation
  • [ ] Added an Architectural Decision Record (ADR), if appropriate
  • [ ] Added an MPLv2 License Header if appropriate
  • [ ] Updated the Changelog

Description

Introduces the concept that any running flowmachine session (server, in notebook, wherever) has a unique identifier, and records, in Redis, when it is actively managing a query (i.e. doing anything with a query that would trigger a state transition). This allows us to introduce an exit handler, where any queries not being managed are released for another session to work with.

This is not ready yet, because I haven't thought through all the intricacies. Be good to get some additional brain power on it.


  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • https://app.asana.com/0/0/1202108561633857

greenape avatar Nov 08 '21 13:11 greenape



Test summary

43 0 0 0Flakiness 0


Run details

Project FlowAuth
Status Passed
Commit af13f121de
Started May 23, 2022 9:22 AM
Ended May 23, 2022 9:29 AM
Duration 07:25 💡
OS Linux Debian - 10.5
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Nov 08 '21 14:11 cypress[bot]

Codecov Report

Merging #4499 (5251046) into master (118b443) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5251046 differs from pull request most recent head af13f12. Consider uploading reports for the commit af13f12 to get more accurate results

@@           Coverage Diff           @@
##           master    #4499   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files         276      276           
  Lines       10760    10760           
  Branches     1308     1308           
=======================================
  Hits        10101    10101           
  Misses        525      525           
  Partials      134      134           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Mar 24 '22 10:03 codecov[bot]